[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #443: post-commit hook script (error) output lost

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-05-12 10:40:23 CEST

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> On Wed, 11 May 2005, Madan US wrote:
>
>> On Tue, 2005-05-10 at 06:53, Philip Martin wrote:
>> > "Madan US" <madan@collab.net> writes:
>> >
>> > That's an ABI change in a public interface so it's not acceptable.
>> > You need to retain svn_commit_callback_t and provide a new name,
>> > svn_commit_callback2_t say, with the new parameter.
>> Whats ABI? I think all functions, pointers that comply to
>> svn_commit_callback_t have been touched in this patch. However, I
>> understand the client-server version compatibility issue. Is this your
>> concern. Could you please explain your concern with an illustration ( a
>> scenario ) so that I can make changes with an inherent understanding...
>> this would also be a learning for me. Thanks.
>
> ABI means Application Binary INterface. It includes things as function
> calling conventions (in what order arguments are put on the stack, where
> the return value is placed etc.) and other things that ensures binary
> compatibility. When *we* talk about ABI breakage we mean that code linked
> to one version of the library will not work with a later version. Adding
> (or removing or changing) the arguments to a function is obviously an ABI
> change; it will make the program crash or something similar. Changing the
> contents of a structure is often an ABI change (some might argue it always
> does). Read more about our compatibility rules in HACKING.

Look at svn_client_status2/svn_wc_status_func2_t and see how we still
provide a working svn_client_status/svn_wc_status_func_t.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 12 23:25:52 2005

This is an archived mail posted to the Subversion Dev mailing list.