[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: wcprops not updated on commit when entries has UTF-8 chars in repository URL

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-05-12 14:00:46 CEST

On Thu, 12 May 2005, Hiroharu Tamaru wrote:

> I've been off this list for some time, so my appologies if
> it has been mentioned already.
>
> I am using subversion 1.1.4 and TortoiseSVN 1.1.3(and also
> 1.1.7).
>
> I found a fuzzy behaviour which may be a bug in subversion
> or TortoiseSVN. I couldn't conclude on which to blame,
> since I couldn't find the concrete API definition for the
> 'entries' file.
>
> If a .svn/entries file have a repository URL that has RAW
> (as opposed to %-escaped) utf-8 characters within it, a
> commit of a file does not update the revision number that
> appears in the files in .svn/wcprops/* .
>
Non-ASCII characters are not allowed in a URI, so there is a bug if
something lets such characters in. My guess is that something strips the
repository root part from an URL and getting it wrong since the
%-escapings don't match. (We have had similar bugs before.)

> Other random things that I noticed:
>
...
> O subversion-1.1.4 %-escapes all non-ASCII chars that were
> given on the command line at the time of check out, as
> well as the non-ASCII chars in subdirectory names under
> the checked-out root, where as TortoiseSVN leaves the
> repository part raw, and only escapes the subdirectory
> part. Therefore, a WC checked out by TortoiseSVN has the
> above mentioned problem for commits performed by either
> subvesrion or TortoiseSVN, whereas a WC checked out by
> subversion are handled correctly by both subverson AND
> TortoiseSVN.
>
That must be a bug in TortoiseSVN.

> O subversion as well as TortoiseSVN do not %-escape the
> name="..." part in the .svn/entries file, and the first
> line of this file says encoding="utf-8", so the use of
> utf-8 itself did not look as to be forbidden in this file.
>
The name attribute is not an URL, but a path, so it shouldn't be
%-escaped.

> Now to the final part:
>
> Should subversion be more gracefull and process the raw
> utf-8 url correctly, or should TortoiseSVN be more strict
> and always %-escape every non-ASCII chars?
>
I don't think we should handle this situation, but maybe we should find
some way to error out, so it gets noticed earlier. I don't know enough
about how DAV handles wcprop to give a good answer here.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 12 13:55:55 2005

This is an archived mail posted to the Subversion Dev mailing list.