[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svn blame --xml' - v5

From: <alexander_at_collab.net>
Date: 2005-05-12 11:44:23 CEST

On Wed, 2005-05-11 at 16:42 +0200, Peter N. Lundblad wrote:
> On Mon, 9 May 2005 alexander@collab.net wrote:
>
> I committed a variant of this patch in r14690. I fixed some bugs and style
> nits. Please take a look at the diff to see what I did and feel welcome to
> ask why I did what I did if you want. (And a final review would also be
> welcome if I did any stupid mistakes:-)
>

Thanks Peter :-). I gone though r14690, got some questions and a
bug to be fixed. Let start with the bugs first

Bug:-
  * Multiple targets on blame, if one of the target is either a
directory or a un-revisioned file, we will get a incomplete xml output
and blame terminates prematurely.

Questions:-
  * Any good reason why U deprecated print_blame_xml function and
putting all tags in to callback function 'blame_receiver_xml' ?. I think
print_blame_xml function give us much more structured code and also
similar to traditional blame output code fragment.

  * Traditional output for blame on multiple targets now gives confusing
result. Should this be fixed?. Discussion on this with Ben, Julian, ...
could be found in http://svn.haxx.se/dev/archive-2005-04/1699.shtml

> > * subversion/tests/clients/cmdline/blame_tests.py
> > (blame_in_xml): New test for blame --xml
> > (blame_on_unknown_revision): New test for blame output on
> > unknown revision
> I didn't find this last test, but it would be useful. Please submit a
> separate patch if you have it somewhere.
>

I will write one, but could U explain 'unknown_revision' or tell me how
to reproduction this. My understanding about it is very limited and what
I know is, every thing that goes into subversion are versioned so how
come UNKOWN-VERSION?

Thanks
-Alexander Thomas (AT)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 12 11:47:05 2005

This is an archived mail posted to the Subversion Dev mailing list.