[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14699 - trunk/subversion/clients/cmdline

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-05-12 02:24:50 CEST

Jani Averbach wrote:
> On 2005-05-11 17:20-0500, kfogel@tigris.org wrote:
>
>>Author: kfogel
>>New Revision: 14699

>> (main): Make sure the argument to --limit is numeric.

>>+ opt_state.limit = strtol (opt_arg, &end, 10);
>>+ if (end == opt_arg || *end != '\0')
>
> This won't allow following:
>
> svn log --limit "42 "

Correct. Do you think it should? It's consistent with GNU "tail" at least:

~/src/subversion> ls | tail -n "42 "
tail: 42 : invalid number of lines
~/src/subversion> tail --version
tail (coreutils) 5.2.1

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 12 02:43:43 2005

This is an archived mail posted to the Subversion Dev mailing list.