[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Optimize svn log --limit

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2005-05-11 23:57:31 CEST

Thanks for the review!

Peter N. Lundblad wrote:
[snip]
>
> Instead of walking through all 150000 revisions, couldn't you keep
> track of the next interesting revision (the largest revision of the
> revisions in the histories array and jump directly to it? Seems like a
> not so important improvement, but anyway.

Yes, good idea -- save needless loops.

[snip]
>
> And here comes the thing that makes this review worth reading: if the
> user wanted the log in reverse order (youngest to oldest, as is the
> default), instead of adding all revisions to an array, why not just
> send the revision to the caller right here? This would make log really
> streamy, even without a limit argument.
>
>

Actually, I had started doing it all this way before I realized I couldn't
read history forward. You have another good point, though, backward reading
can be completely streamy even if forward can't.

Thanks, I'll post a new version with these and the style fixes.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 12 01:10:33 2005

This is an archived mail posted to the Subversion Dev mailing list.