[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14678 - in trunk/subversion: libsvn_fs_fs tests/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2005-05-11 19:05:17 CEST

"D.J. Heap" <dj@shadyvale.net> writes:
> Thanks for the review -- I'll clean it up. Is there a code style
> analyzer/tool that would help me catch these for Subversion's style?
> I believe I know the style guides, but since it's different than my
> work's I keep slipping and have a hard time seeing them even when
> looking right at them.

There probably are such tools, but I'm not familiar with them. Don't
worry too much; just do your best and if some minor formatting nits
get caught in review -- or don't get caught at all -- it's not a
tragedy.

> Previously, I did think the write lock was necessary due to it being
> implemented with multiple files -- but re-reading the code again, I
> don't think so. The lock files are written out in child-first order
> and separated by path elements. Even if the hotcopy grabs some
> locks-in-progress or unlocks-in-progress, it should be fine. Thanks
> for the sanity check -- I'll remove the write lock.

Thanks for the quick turnaround!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 11 21:42:35 2005

This is an archived mail posted to the Subversion Dev mailing list.