[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav autoversioning bug... not good.

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-05-10 21:55:42 CEST

On May 10, 2005, at 12:49 PM, C. Michael Pilato wrote:

> So, Ben, Fitz and I dove into this, and saw that the is_xml_comment
> flag in the lock was being clobbered.

Bug is now fixed. I can confirm this via hand-tests, by pasting LOCK
and subsequent PROPFIND requests into netcat, simulating what a
generic dav client (like dreamweaver) does.

The fix is very simple: propogate the svn_lock_t boolean field into
the public svn_fs_lock() API. Of course the patch *looks* huge,
touching 16 files due to the API change... but the actual amount of
logical code-churn is close to zero. It's really easy to review.

As soon as 'make check' passes over ra_dav, I'll commit the change
and nominate for 1.2.x. As I said before, I think this bug is a
showstopper for the 1.2 autoversioning feature, and warrants an rc4
release. (Maybe breser can roll rc4 later this evening?)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 10 21:57:47 2005

This is an archived mail posted to the Subversion Dev mailing list.