[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14643 - in trunk/subversion: include libsvn_client libsvn_ra_dav libsvn_repos libsvn_wc

From: Jani Averbach <jaa_at_jaa.iki.fi>
Date: 2005-05-09 21:41:55 CEST

On 2005-05-09 12:16-0500, kfogel@collab.net wrote:
>
> I thought about doing that, but my feeling was: we've had a clear pool
> usage policy for a long time, and those callers aren't doing what they
> ought to be, we need to find out about it. We can fix them in 1.2.1
> if necessary.

Ok, I just like to be (overly) cautious. One quick question: How deep
is this recursion? One level?

less -N subversion/libsvn_repos/dump.c
 295 dump_node (struct edit_baton *eb,
 296 const char *path,
 ...
 378 /* recurse: print an additional add-with-history record. */
 379 SVN_ERR (dump_node (eb, path, kind, svn_node_action_add,
 380 is_copy, compare_path, compare_rev, pool));
 ...

Because this is one place where dump_node is recursing, and later
there is a branch where it is using svn_stream_copy which does initial
apr_palloc.

BR, Jani

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 9 21:43:01 2005

This is an archived mail posted to the Subversion Dev mailing list.