[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14624 - trunk/subversion/mod_dav_svn

From: <kfogel_at_collab.net>
Date: 2005-05-09 07:32:05 CEST

brane@tigris.org writes:
> Log:
> Remove the <prop> element from mod_dav_svn's XML DTD for GET. It's not
> used and never will be, according to policy.
>
> * subversion/mod_dav_svn/repos.c (dav_svn_deliver): Change the DTD,
> comments, and geneated <dir> and <file> elements.
>
> --- trunk/subversion/mod_dav_svn/repos.c (original)
> +++ trunk/subversion/mod_dav_svn/repos.c Sun May 8 03:41:08 2005
>
> [...]
>
> @@ -2375,11 +2371,11 @@
> else
> {
> const char *const tag = (is_dir ? "dir" : "file");
> -
> +
> /* ### This is where the we could search for props */
>
> ap_fprintf(output, bb,
> - " <%s name=\"%s\" href=\"%s\"></%s>\n",
> + " <%s name=\"%s\" href=\"%s\" />\n",
> tag, name, href, tag);
> }
> }

Was this changed to a self-closing element because we know we'll never
put "<prop>" elements inside it in the future?

If so, shouldn't the comment above it go away too?

Or if not, then why was it changed to self-closing?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 9 08:06:06 2005

This is an archived mail posted to the Subversion Dev mailing list.