Philip Martin wrote:
> I'm getting lots of failures on trunk, the following is typical:
>
> $ ~/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py
> --cleanup 1
>
> /home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py:159:
> SyntaxWarning: local name 'message' in 'run_and_verify_svn' shadows use of
> 'message' as global in nested scope 'handle_output' def
> run_and_verify_svn(message, expected_stdout, expected_stderr, *varargs):
> UNEXPECTED EXCEPTION:
> Traceback (most recent call last):
> File
>
>
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/testcase.py",
> line 105, in run rc = apply(self.pred.func, args) File
>
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/basic_tests.py",
> line 76, in basic_checkout svntest.actions.run_and_verify_svn(None,
> None, [], 'rm', G_path) File
>
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py",
> line 185, in run_and_verify_svn handle_output(expected_stderr, err,
> 'stderr', SVNExpectedStderr) File
> "/home/pm/sw/subversion/svn/subversion/tests/clients/cmdline/svntest/actions.py",
> line 174, in handle_output compare_and_display_lines(message,
> output_type.upper(), expected, actual)
> NameError: global name 'message' is not defined
> FAIL: basic_tests.py 1: basic checkout of a wc
>
> I'm using:
>
> $ python -V
> Python 2.1.3
>
> If I google I one of the first hits is me complaining about r7351! As
> far as I can tell this use of nested functions requires a more recent
> Python, the testsuite is supposed to work with 2.1.3 isn't it?
Supposed to, yes. But, as a practical matter, very few people actually use
Python less than 2.2 these days, so it is extremely easy for modern Python
styles to creep in, and remain undetected for a while.
I suppose, if we are serious about python 2.0 compat, we ought to see if any
of the people running svn-breakage systems would be willing to arrange for
the tests to run with an old python.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 8 16:05:56 2005