[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: rfc for proposal on solving issue #443

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-05-05 14:51:11 CEST

Marcus Rueckert wrote:

>On 2005-05-05 04:45:28 -0700, Madan US wrote:
>
>
>>>> #443 is about propagating the post-commit hook failure back to the
>>>>
>>>>
>>>does the client really wait until the post-commit is ran? i thought it
>>>would disconnect before the hook is ran.
>>>
>>>
>>I dont think it happens that way.
>>Inside dav_svn_merge(), The svn_repos_fs_commit_txn() function ( which
>>internally exectues the post-commit hook ) is called before calling
>>dav_svn__merge_response() which creates the merge-response.
>>And the run_hook_cmd() waits for the post-commit hook to return.
>>
>>
>
>strange... is this documented for hook authors somewhere?
>i dont see it in the book. this is bad. because the book mentions
>hotbackup.py ... and this script can use quite some time for larger
>repositories.
>
>
Hooks are always run synchronously. It's up to the hook author to decide
whether to make long-lasting operations asynchronous within the hook or not.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 5 14:52:27 2005

This is an archived mail posted to the Subversion Dev mailing list.