[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: rfc for proposal on solving issue #443

From: Madan US <madan_at_collab.net>
Date: 2005-05-05 13:45:28 CEST

On Thu, 2005-05-05 at 17:02, Marcus Rueckert wrote:
On 2005-05-05 03:57:46 -0700, Madan US wrote:
> > #443 is about propagating the post-commit hook failure back to the
> does the client really wait until the post-commit is ran? i thought it
> would disconnect before the hook is ran.
I dont think it happens that way.
Inside dav_svn_merge(), The svn_repos_fs_commit_txn() function ( which
internally exectues the post-commit hook ) is called before calling
dav_svn__merge_response() which creates the merge-response.
And the run_hook_cmd() waits for the post-commit hook to return.
> i would think it can cause a bit trouble if you have long running
> post-commits.
true... delays may also cause timeouts!!!
> i think simple logging of those might be better, but that
> is stuff for the hook script authors.
True, the hook script authors have to take care of this.
btw, what do you think of the idea I mentioned?!

Thanks,
Madan.
darix

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 5 13:46:36 2005

This is an archived mail posted to the Subversion Dev mailing list.