[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svn blame --xml' - v2

From: Dominic Anello <danello_at_danky.com>
Date: 2005-05-04 16:37:50 CEST

On 2005-05-04 10:11:14 +0200, Peter N. Lundblad wrote:
> On Wed, 4 May 2005, [utf-8] ?^Xyvind A. Holm wrote:
>
> > On 2005-05-04 08:24:09 Peter N. Lundblad wrote:
> > > On Wed, 4 May 2005, [utf-8] ?^Xyvind A. Holm wrote:
> > > > On 2005-05-02 05:09:09 alexander@collab.net wrote:
> > > > > Version: 2, Patch to add XML output for 'svn blame'
> > > > [...]
> > > > - And the actual text line with it's own element from the file is
> > > > missing in the XML.
> > >
> > > That's deliberate (see the feedback to the first version of the
> > > patch). In short, we don't know the encodig of the file content, so we
> > > can't include it in XML (which has to be UTF8, or some or some other
> > > encoding, but it has to be consistent.) It is easy to get at the
> > > content with svn cat.
> >
> > Yes, that's a good reason not to include the actual line text. But what
> > about including the actual line number instead? XML suggestion:
> >
> With an entry element for each line, I don't see a point in showing that
> the computer can count:-) Remember that this isn't for humans.
----8<----

If I can chime in here, I think a line number associated with each entry
might be nice because you might not want to process the XML document
sequentialy. For example, I might want to report all the line numbers
that changed in rev 456. The easiest way to get these entries using
XPath would be to do a query like //entry[@revision="456"]. However,
this just gives me a collection of nodes without any context, so I'd
need a <line> element if I wanted to be nice and lazy ;-)

-Dominic

  • application/pgp-signature attachment: stored
Received on Wed May 4 16:39:23 2005

This is an archived mail posted to the Subversion Dev mailing list.