On 2005-05-02 05:09:09 alexander@collab.net wrote:
> Version: 2, Patch to add XML output for 'svn blame'
I tried it, and this is a nice functionality. Only a couple of comments
about the XML:
<?xml version="1.0" encoding="utf-8"?>
<blame>
<target
path=".bashrc">
<entry
revision=" 32">
<author>sunny</author>
<time>1999-07-02 18:36:59 +0200 (fre, 02 jul 1999)</time>
</entry>
<entry
revision=" 3245">
<author>sunny</author>
<time>2005-02-09 03:34:58 +0100 (ons, 09 feb 2005)</time>
</entry>
...
</blame>
- The date used is the long "human readable" format which is I18Ned.
The format is not epsecially compact (duplicates the info) and
changes according to the locale used. In XML, the date should be
compact and, consistent and preferrably in GMT. This is the format
used by svn log:
<date>2005-05-03T09:43:19.160459Z</date>
which looks pretty perfect to me.
- There is some space padding in the revision= attribute in the
<entry> element, that should be stripped.
- And the actual text line with it's own element from the file is
missing in the XML.
-- sunny256
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 4 08:04:25 2005