"C. Michael Pilato" <cmpilato@collab.net> writes:
> In that case, yes, I think this code is correct. I'm not fond of the
> mid-boolean-logic comment placement,
Happy to change that.
> and, what's more, would prefer
> that the code also explicitly check for the SEGFAULT cause -- that
> parent_status->entry is NULL.
I'd rather not do that; we could cover up a lot of bugs that way.
Basically, we have every right to expect that parent_status->entry
exists *unless* one of several possible unversioned scenarios is true.
We should check for those scenarios, but not cover up the problem if
parent_status->entry is unexpectedly NULL.
> But I think you can confidently commit your solution knowing that
> svn_wc_status_external is only ever set on unversioned items. In
> other words, svn_wc_status_external is just a particular flavor of
> unversioned item -- we chose to reveal an item as external by using
> unique status->text_status value instead of some new boolean
> status->is_external. And this conditional's job is to rule out (among
> other things) unversioned items.
Thanks. I also did some more investigating and realized that one of
my fears about the patch was groundless: status on the external
directory within the target is still performed as usual. That was
what I'd worried might break.
Committed in r14514.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 29 17:01:19 2005