[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14473 - trunk/subversion/libsvn_fs_base

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-28 21:51:06 CEST

kfogel@collab.net writes:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
> > > --- trunk/subversion/libsvn_fs_base/tree.c (original)
> > > +++ trunk/subversion/libsvn_fs_base/tree.c Wed Apr 27 10:19:45 2005
> > > @@ -1404,7 +1404,7 @@
> > > if (root1->fs != root2->fs)
> > > return svn_error_create
> > > (SVN_ERR_FS_GENERAL, NULL,
> > > - _("Asking props changed in two different filesystems"));
> > > + _("Cannot compare property value between two different filesystems"));
> >
> > Shouldn't that be "property values"?
>
> I don't think so. It's a matter of taste. Suppose I phrased it like
> this:
>
> "Cannot compare property's value..."
>
> See what I mean? Until you do the comparison, you don't know if there
> are one or two values in play here.

Actually, all of these suggestions are incomplete. The question asked
by the caller of this function is, "Are there any property differences
between root1 and root2?" The answer involves not just looking at
property values where the set of properties is the same, it also means
noticing where properties were added or removed.

None of this matter, though. The error is thrown because the two
roots fail to point to the same filesystem object. Suggest the more
straightforward:

    Cannot compare roots from two different filesystems.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 28 22:33:31 2005

This is an archived mail posted to the Subversion Dev mailing list.