[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14478 - in trunk/subversion: tests/libsvn_subr

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2005-04-28 21:01:04 CEST

On Thu, 2005-04-28 at 19:00 +0100, Philip Martin wrote:
>"Peter N. Lundblad" <peter@famlundblad.se> writes:
>
>> On Thu, 28 Apr 2005, Philip Martin wrote:
>>
>>> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>>>
>>> >> + if (path[j] == ':' || path[j] == '/')
>>> >> + break;
>>> >>
>>> > Please put multiline statements in braces.
>>>
>>> I don't think that is an improvement.
>>>
>> It was pointed out to me before that that's our convention.
>
>Really? I wasn't aware we had such a convention. I don't think the
>code in question needs braces, if some convention "requires" that they
>be added then I think the convention should be changed. Stupid rules
>don't help.
>
Perhaps showing my ignorance here, but I understood the "multi-line"
portion of that rule to apply to the block, not the conditional plus the
block. From what I've seen, that matches the existing usage pattern
more closely, and is generally a more useful guideline for improving
code comprehensibility.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 28 21:25:47 2005

This is an archived mail posted to the Subversion Dev mailing list.