[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: warn about misspelled props?

From: Fabien COELHO <fabien_at_coelho.net>
Date: 2005-04-28 17:23:39 CEST

>>> [madan@madan A]$ svn ps svn:asdf "value" mu
>>> WARNING 'svn:asdf' is not an svn standard property.
>> Or should svn:* property be reserved, and any unknown prop coldly refused?
>> Or have --force to set it anyway?
> I think this would be a double-edged sword. If we reserve it, or check
> for misspellings, then we potentially cause bad user interactions for
> users with old clients whenever we add a new property.

If an old client is used on a newer repos, maybe it is time to upgrade;-)

Having a mispelled svn property that is noticed much later is also kind of
a bad user interaction.

> Perhaps a better solution might be to check the property names in the
> pre-commit hook to make sure they're valid svn properties?

That has been suggested, but I feel it is too strong and too late:

you cannot just send a warning from pre-commit, you can only abort the
commit, so there would be no way to put a non standard svn:* property,
which would be bad: for instance, I could use the old svn and set up the
repos for some new upcoming props (e.g. svn:need-lock) before the repos
soft is actually upgraded.

One could think that the repos could advertise the 'svn:*' properties that
it accepts... well that could also be a property;-)

So I think that a warning is fine, or an error with a force option.

The "reserved" stuff is more a suggestion on which I have no real
technical opinion.

From the implementation point of view, it is quite simple to implement
that in a client, but having the list of set properties with svnlook from
within pre-commit does not look that easy.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 28 18:24:50 2005

This is an archived mail posted to the Subversion Dev mailing list.