[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] asking props (was Re: asking props)

From: Karol Szkudlarek <karol_at_mikronika.com.pl>
Date: 2005-04-28 10:30:34 CEST

kfogel@collab.net wrote:
> Karol Szkudlarek <karol@mikronika.com.pl> writes:
>
>>Now it's clear to me. Thanks. The message also appears in another file:
>>libsvn_fs_fs/tree.c:1153.
>>
>>And similar two messages are located here:
>>
>>#: libsvn_fs_base/tree.c:3937 libsvn_fs_fs/tree.c:2593
>>msgid "Asking contents changed in two different filesystems"
>
>
> Thanks for noticing!
>
> Could I persuade to you to post a patch for these? See HACKING and
> http://subversion.tigris.org/mailing-list-guidelines.html#patches for
> guidelines on sending patches.
>
> If you don't have time for it, that's fine, just let us know.
>
> -Karl
>
Hi!

OK I prepared a patch. Here is the log message:

* subversion/libsvn_fs_base/tree.c
  (base_contents_changed),
  subversion/libsvn_fs_fs/tree.c
  (fs_contents_changed): Improve an overly terse error message.

* subversion/libsvn_fs_fs/tree.c
  (fs_props_changed): Message fixed from r14473 also appears here.

Regards,
Karol Szkudlarek

Index: libsvn_fs_base/tree.c
===================================================================
--- libsvn_fs_base/tree.c (wersja 14491)
+++ libsvn_fs_base/tree.c (kopia robocza)
@@ -3934,7 +3934,7 @@
   if (root1->fs != root2->fs)
     return svn_error_create
       (SVN_ERR_FS_GENERAL, NULL,
- _("Asking contents changed in two different filesystems"));
+ _("Cannot compare path between two different filesystems"));
 
   /* Check that both paths are files. */
   {
Index: libsvn_fs_fs/tree.c
===================================================================
--- libsvn_fs_fs/tree.c (wersja 14491)
+++ libsvn_fs_fs/tree.c (kopia robocza)
@@ -1150,7 +1150,7 @@
   if (root1->fs != root2->fs)
     return svn_error_create
       (SVN_ERR_FS_GENERAL, NULL,
- _("Asking props changed in two different filesystems"));
+ _("Cannot compare property value between two different filesystems"));
   
   SVN_ERR (get_dag (&node1, root1, path1, pool));
   SVN_ERR (get_dag (&node2, root2, path2, pool));
@@ -2590,7 +2590,7 @@
   if (root1->fs != root2->fs)
     return svn_error_create
       (SVN_ERR_FS_GENERAL, NULL,
- _("Asking contents changed in two different filesystems"));
+ _("Cannot compare path between two different filesystems"));
   
   /* Check that both paths are files. */
   {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 28 10:36:22 2005

This is an archived mail posted to the Subversion Dev mailing list.