[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Multiline log message checking

From: Vivek <vivek_at_collab.net>
Date: 2005-04-28 05:47:03 CEST

On Wed, 2005-04-27 at 20:26, kfogel@collab.net wrote:

> By convention, the stuff between "[[[ ... ]]]" is the log message.
> But the above is not your log message, and also isn't very clear :-).
> I can't tell if it's fixing a bug in Subversion, or fixing a test for
> a bug, or something else.
Oops Sorry. It just adds some muscles(ligaments?) to log_tests.py.
>
> Your real (attached) log message was this:
>
> Added multiline log checking in log_tests.py
>
> */subversion/tests/clients/cmdline
> guarantee_repos_and_wc(sbox):Code to create
> multiline log messages to even numbered commits.
> parse_log_output(log_lines):Added a new key
> 'lines' in the hash to test it against revision
> check_log_chain (chain, revlist):The actual
> checking takes place here. But nothing fancy.
> log_through_copyfrom_history(sbox):change log
> message.
>
> Some formatting comments: you don't need to include the parameters
> when naming methods. But you should wrap the methods themselves in
> parens. Please have a space after a colon, and after the asterisk.
> See HACKING, and also run 'svn log', for guidelines and example log
> messages.
Ok.
>
> The change itself looked good; I had one comment, see below.
>

> Don't be afraid to remove stuff like that -- it's all under version
> control anyway :-).
Unmercifully removed the old comment. While in the same state, edited
some other comments also. Reposting ...
Thanks Karl.
Vivek
>
> -Karl

Added multiline log checking in log_tests.py

* /subversion/tests/clients/cmdline
 (guarantee_repos_and_wc): Code to create
 multiline log messages to even numbered commits.
 (parse_log_output): Added a new key
 'lines' in the hash to test it against revision
 (check_log_chain): The actual
 checking takes place here. But nothing fancy.
 (log_through_copyfrom_history): change log
 message.

 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Apr 28 05:47:25 2005

This is an archived mail posted to the Subversion Dev mailing list.