[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate

From: <kfogel_at_collab.net>
Date: 2005-04-26 21:18:09 CEST

Mark Phippard <MarkP@softlanding.com> writes:
> Doing some more testing I discovered this bug in JavaHL. In the method to
> return the lockCreationDate for an item it is instead returning the date
> of the last commit.
>
> Is it OK if I commit this to trunk?
>
> [[[
> Return correct date for lockCreationDate
>
> * bindings/javahl/src/org/tigris/subversion/javahl/Status.java
> Corrected the date field that was returned in getLockCreationDate()
> ]]]
>
> Index: javahl/src/org/tigris/subversion/javahl/Status.java
> ===================================================================
> --- javahl/src/org/tigris/subversion/javahl/Status.java (revision 14452)
> +++ javahl/src/org/tigris/subversion/javahl/Status.java (working copy)
> @@ -538,7 +538,7 @@
> if (lockCreationDate == 0)
> return null;
> else
> - return new Date(lastChangedDate / 1000);
> + return new Date(lockCreationDate / 1000);
> }
>
> /**

That seems like such an obvious cut-and-pasto (from line 246, to be
precise), that even though I don't know much about the JavaHL
bindings, I'm happy to +1 this and share the risk with you :-).

Go for it!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 26 21:49:41 2005

This is an archived mail posted to the Subversion Dev mailing list.