[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14407 - trunk/subversion/tests/clients/cmdline/svntest

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-04-22 21:21:23 CEST

On Fri, 2005-04-22 at 20:05 +0100, Philip Martin wrote:
> fitz@tigris.org writes:
>
> > Author: fitz
> > Date: Fri Apr 22 11:41:39 2005
> > New Revision: 14407
>
> > @@ -619,6 +619,8 @@
> > for opt, val in opts:
> > if opt == "--url":
> > test_area_url = val
> > + if test_area_url[-1:] == '/': # Normalize url to have no trailing slash
> > + test_area_url = test_area_url[:-1]
>
> Move this code lower down to handle BASE_URL=xxx as well as --url=xxx.

Done in r14411.

> How about "while" instead of "if" to handle multiple slashes, or is
> that a bad thing?

I think it is a bad thing. While http://localhost/ looks fine
http://localhost//// seems wrong.

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 22 21:20:46 2005

This is an archived mail posted to the Subversion Dev mailing list.