[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14381 - in trunk: subversion/tests/clients/cmdline

From: VK Sameer <sameer_at_collab.net>
Date: 2005-04-22 19:26:33 CEST

On Thu, 2005-04-21 at 16:24 -0500, lundblad@tigris.org wrote:

> Modified: trunk/subversion/tests/clients/cmdline/davautocheck.sh
> +function trap_cleanup() {
> + [ -e "$HTTPD_PID" ] \
> + && kill $(cat "$HTTPD_PID")
> + exit 1
> +}
...
> -kill $(cat "$HTTPD_PID")
> +[ -e "$HTTPD_PID" ] \
> + && kill $(cat "$HTTPD_PID")

Some redundancy here. Also, by this time, $HTTPD_PID will exist, so no
check is needed, unlike if the trap function is re-used.

Regards
Sameer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 22 19:29:03 2005

This is an archived mail posted to the Subversion Dev mailing list.