[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14333 - trunk/subversion/libsvn_fs_fs

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-04-21 04:12:15 CEST

On Wed, 2005-04-20 at 16:37, ringstrom@tigris.org wrote:
> - {
> - copyfrom_string = apr_pstrdup (copyfrom_pool, "");
> - }
> + copyfrom_string = NULL;
[...]
> - SVN_ERR (svn_io_file_write_full (file, copyfrom, strlen (copyfrom), NULL,
> - pool));
> + if (copyfrom)
> + {
> + SVN_ERR (svn_io_file_write_full (file, copyfrom, strlen (copyfrom),
> + NULL, pool));
> + }

Why not just set copyfrom_string = "" and avoid the conditional later
on?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 21 04:13:20 2005

This is an archived mail posted to the Subversion Dev mailing list.