[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13973 - in trunk/subversion: include libsvn_repos libsvn_subr

From: <kfogel_at_collab.net>
Date: 2005-04-20 20:34:04 CEST

I committed some doc string tweaks to this in r14327.

> --- trunk/subversion/libsvn_repos/hooks.c (original)
> +++ trunk/subversion/libsvn_repos/hooks.c Wed Apr 6 08:42:00 2005
> @@ -83,37 +84,44 @@
> return svn_error_wrap_apr
> (apr_err, _("Error closing write end of stderr pipe"));
>
> - /* Function failed. */
> if (err)
> {
> err = svn_error_createf
> - (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to run '%s' hook"), cmd);
> + (SVN_ERR_REPOS_HOOK_FAILURE, err, _("Failed to start '%s' hook"), cmd);
> }
> -
> - if (!err)
> + else
> {
> - /* Command failed. */
> - if (! APR_PROC_CHECK_EXIT (exitwhy) || exitcode != 0)
> - {
> - svn_stringbuf_t *error;
> + svn_stringbuf_t *error;
> + svn_error_t *err2;
>
> - if (read_errstream)
> + err2 = svn_stringbuf_from_aprfile (&error, read_errhandle, pool);
> +
> + err = svn_io_wait_for_cmd(&cmd_proc, cmd, &exitcode, &exitwhy, pool);

I did not commit the addition of a space before the opening paren
here, however :-). Fixing that nit would not be worth creating
conflicts with outstanding patches or branches.

Didn't see any code problems in the patch.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 20 21:03:55 2005

This is an archived mail posted to the Subversion Dev mailing list.