[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Stop 'svn import' from importing empty paths

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-15 20:26:34 CEST

"S.Ramaswamy" <ramaswamy@collab.net> writes:

> I checked around to see if I was pioneering the use of single
> variable batons before sending the patch - saw one in
> simple_provider.c or some such - I will add the additional members
> that you suggested in the other mail.

Okay. Cool.

> > I think it makes more sense to put this boolean setting line
> > immediately after the editor->add_directory() calls to which it
> > corresponds. Yes, that means it will get hit multiple times,
>
> ... which is why I didn't put it there; will move it up.

Thanks.

> Should the existing import tests be moved from basic_tests.py to the new
> import_tests.py ?

There should be a single "basic import" test left in basic_tests.py.
If there are other import tests in there that aren't claiming to test
some "basic" functionality, I'd be fine with moving them into the new
test file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 15 20:32:32 2005

This is an archived mail posted to the Subversion Dev mailing list.