[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add svn_ra_initialize

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-14 20:50:30 CEST

On Thu, 14 Apr 2005, Greg Hudson wrote:

> On Thu, 2005-04-14 at 01:52, Peter N. Lundblad wrote:
> > > If svn_ra_initialize is present in 1.2 then we can require that it be
> > > called before any other "new in 1.2" function. Most of the svn_ra_xxx
> > > stuff happens to be new in 1.2, we deprecated the vtable approach.
>
> > Yeah, it is cleaner to have an "you must call this function" than "you
> > should call this function, but if you don't, it will hopefully work
> > anyway". New functionality can rely on this being called in the future.
>
> I'm not quite sure what the value is here. Old code is going to invoke
> new RA functions via libsvn_client anyway, without calling
> svn_ra_initialize().
>
Good point. We'll have to live with the "should call" thing then. I'll
withdraw it from STATUS.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 14 20:45:06 2005

This is an archived mail posted to the Subversion Dev mailing list.