[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14131 - trunk/subversion/libsvn_fs_fs

From: <kfogel_at_collab.net>
Date: 2005-04-12 18:46:03 CEST

"Brian W. Fitzpatrick" <fitz@collab.net> writes:
> > --- trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> > +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Mon Apr 11 17:36:51 2005
> > @@ -279,15 +279,20 @@
> > err = svn_io_read_version_file (&format, path_format (fs, pool), pool);
> > if (err && APR_STATUS_IS_ENOENT (err->apr_err))
> > {
> > - /* Pre-1.2 filesystems did not have a format file (you could say
> > - they were format "0"), so they get upgraded on the fly. */
> > - svn_error_clear (err), err = NULL;
> > - format = SVN_FS_FS__FORMAT_NUMBER;
> > - SVN_ERR (svn_io_write_version_file
> > - (path_format (fs, pool), format, pool));
> > + /* Treat an absent format file as format 1. Do not try to
> > + create the format file on the fly, because the repository
> > + might be read-only for us, or we might have a umask such
> > + that even if we did create the format file, subsequent
> > + users would not be able to read it.
>
> Given that elsewhere we use svn_fs_fs__dup_perms, I don't think that
> having the wrong umask is really a valid reason for not creating the
> format file (I agree with the spirit of the fix, however).

Comment tweaked in r14148.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 12 19:17:21 2005

This is an archived mail posted to the Subversion Dev mailing list.