[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposal: Remove svn_test.h from subversion/include/

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2005-04-11 19:10:43 CEST

> kfogel@collab.net wrote:
> > Julian Foad <julianfoad@btopenworld.com> writes:
> >> Max Bowsher wrote:
> >>> I think we should remove svn_test.h from subversion/include/.
> >>> This is a file containing defines which are used strictly by our own
> >>> testsuite.
> >>> OK?
> >>
> >> Yes, indeed. It presumably should go in subversion/tests/ and
> >> probably that directory will need to be mentioned as an extra include
> >> dir in the tests part of the build system.
> >
> > I want it to go away too, but isn't removing a public .h file (even
> > one that we wish no one has been using) against our 1.x compatibility
> > guidelines? I would think the most we can do is deprecate the stuff
> > inside it.
>
> It's a judgement call, of course, but my opinion is that this file was
> never
> really public, since there is _no way_ anyone could have used this file,
> without digging into files beneath subversion/tests/, which are distinctly
> not public. We _never_ installed any code that used those interfaces.

+1, there's nothing usefull in there.

bye,

Erik.

-- 
Sparen beginnt mit GMX DSL: http://www.gmx.net/de/go/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 11 19:14:28 2005

This is an archived mail posted to the Subversion Dev mailing list.