[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn lock" crashes if editor exits without saving a lock message

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-04-08 13:34:22 CEST

On Apr 8, 2005, at 6:30 AM, Philip Martin wrote:

> "Brian W. Fitzpatrick" <fitz@collab.net> writes:
>
>> On Apr 8, 2005, at 2:22 AM, Michael W Thelen wrote:
>>
>>> Both trunk and 1.2.0-rc1 clients will crash if you run "svn lock"
>>> with
>>> no log message, and exit the log message editor without saving.
>>> Below
>>> is the gdb stack trace on my machine (Debian unstable). Clearly a
>>> NULL
>>> comment parameter is being passed all the way through, but I'm not
>>> sure
>>> at which point it ought to be caught and the operation aborted.
>>
>> I'm unable to reproduce this with either emacs or vim (on Debian
>> testing)--which editor are you using?
>
> I can reproduce it, are you using ra_dav?

Doh. I was using ra_local.

> The lock commit message handling is poor. First I get a blank editor
> window with no indication of which files are to be locked, there is
> not even any indication that I should write a log message.
>
> Next, if I exit the editor without writing a log message I don't get
> the "a)bort c)ontinue e)dit" message. Finally because lock uses it's
> own message code rather than the util.c code I don't get the bit of
> code at subversion/clients/cmdline/util.c:607 that converts a NULL
> message into "". The NULL message causes ra_dav to SEGV.

There was some talk about using the same log mechanism that commit does
(dropping the user into the loop with the abort/continue/edit message),
but I believe we skipped it primarily because we could improve upon it
in a later release. In addition, I don't think that lock comments will
typically be as in-depth as a standard commit message.

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 8 13:36:22 2005

This is an archived mail posted to the Subversion Dev mailing list.