[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

"svn lock" crashes if editor exits without saving a lock message

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2005-04-08 09:22:17 CEST

Both trunk and 1.2.0-rc1 clients will crash if you run "svn lock" with
no log message, and exit the log message editor without saving. Below
is the gdb stack trace on my machine (Debian unstable). Clearly a NULL
comment parameter is being passed all the way through, but I'm not sure
at which point it ought to be caught and the operation aborted.

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1214780608 (LWP 19876)]
0xb7f604bc in apr_xml_quote_string (p=0x80809d0, s=0x0,
quotes=-1073746892) at apr_xml.c:537
537 for (scan = s; (c = *scan) != '\0'; ++scan, ++len) {
(gdb) back
#0 0xb7f604bc in apr_xml_quote_string (p=0x80809d0, s=0x0,
quotes=-1073746892) at apr_xml.c:537
#1 0xb7b15b84 in shim_svn_ra_dav__lock (session=0x8087398,
lock=0xbfffe7e8, path=0x8087348 "foo", comment=0x0, force=0,
current_rev=15, pool=0x80809d0)
     at subversion/libsvn_ra_dav/session.c:1011
#2 0xb7b15e8c in svn_ra_dav__lock (session=0x8087398,
path_revs=0x807fe00, comment=0x0, force=0, lock_func=0xb7fdaa0c
<store_locks_callback>, lock_baton=0xbfffe860,
     pool=0x80749a0) at subversion/libsvn_ra_dav/session.c:1100
#3 0xb7f97c3f in svn_ra_lock (session=0x8087398, path_revs=0x807fe00,
comment=0x0, steal_lock=0, lock_func=0xb7fdaa0c <store_locks_callback>,
lock_baton=0xbfffe860,
     pool=0x80749a0) at subversion/libsvn_ra/ra_loader.c:508
#4 0xb7fdb404 in svn_client_lock (targets=0x807eaf8, comment=0x0,
steal_lock=0, ctx=0x8074da8, pool=0x80749a0) at
subversion/libsvn_client/locking_commands.c:369
#5 0x0804f67a in svn_cl__lock (os=0x80749d8, baton=0xbfffe9a8,
pool=0x80749a0) at subversion/clients/cmdline/lock-cmd.c:128
#6 0x080522a1 in main (argc=3, argv=0xbfffec24) at
subversion/clients/cmdline/main.c:1413

--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Received on Fri Apr 8 09:24:23 2005

This is an archived mail posted to the Subversion Dev mailing list.