[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r14002 - in trunk/subversion: include libsvn_fs_base libsvn_fs_fs tests/libsvn_fs_base tests/libsvn_repos

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-04-07 17:40:54 CEST

Philip Martin wrote:
> maxb@tigris.org writes:
>
>> Author: maxb
>> Date: Wed Apr 6 18:51:35 2005
>> New Revision: 14002
>>
>> Modified:
>> trunk/subversion/include/svn_error_codes.h
>> trunk/subversion/libsvn_fs_base/tree.c
>> trunk/subversion/libsvn_fs_fs/fs_fs.c
>> trunk/subversion/libsvn_fs_fs/tree.c
>> trunk/subversion/tests/libsvn_fs_base/fs-test.c
>> trunk/subversion/tests/libsvn_repos/repos-test.c
>> Log:
>> * subversion/include/svn_error_codes.h: Remove unused #include
>> "svn_props.h".
>
> HACKING refers to http://apr.apache.org/versioning.html which states:
>
> We define "source compatible" to mean that an application will
> continue to build without error, and that the semantics will remain
> unchanged.
>
> Applications that write against a particular version will remain
> source-compatible against later versions, until the major number
> changes.
>
> Removing an unsed #include from the public header files means the new
> version is not "source compatible" with the old, if we follow the
> rules strictly then this change needs to wait until 2.0.

/me would rather say "naughty source, #include what you need, don't be
lazy", but given what we've promised, it seems I need to go revert r14002.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 7 17:41:49 2005

This is an archived mail posted to the Subversion Dev mailing list.