[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Locking errors: SVN_ERR_FS_PATH_LOCKED and SVN_ERR_FS_NO_LOCK_TOKEN

From: Brian W. Fitzpatrick <fitz_at_collab.net>
Date: 2005-04-07 15:23:16 CEST

On Apr 6, 2005, at 5:25 PM, Julian Foad wrote:

> Max Bowsher wrote:
>> Julian Foad wrote:
>>> Ben Collins-Sussman wrote:
>>>> On Apr 4, 2005, at 2:36 PM, Julian Foad wrote:
>>>>> Aha! I have just seen that "SVN_ERR_FS_PATH_LOCKED" is tested by
>>>>> the
>>>>> macro "SVN_ERR_IS_LOCK_ERROR", and therefore perhaps is intended
>>>>> only
>>>>> to mean, "You can't lock this path because it is already locked".
>>>>> If
>>>>> that's the case, may we rename it to
>>>>> "SVN_ERR_FS_PATH_ALREADY_LOCKED"?
>>>>> Or at least document it as such.
>>>>
>>>> Yes, I think that's exactly the difference between the two error
>>>> codes.
>>>
>>> Thanks for clarifying it to me. I'll stop pushing for a
>>> clarification in
>>> the source code if no-one else is bothered by it.
>> Actually, now it's been worked out what the issue is, I think this
>> very much *should* be clarified.
>> Preferably by changing the name to _ALREADY_LOCKED as suggested above.
>
> Here's a patch to do so. Note that this can only be done if it is
> ported into v1.2 before v1.2 is released, otherwise it would be an
> incompatible API change.

Much clearer. +1

-Fitz

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 7 15:26:23 2005

This is an archived mail posted to the Subversion Dev mailing list.