Re: [PATCH] Issue #2219: Canonicalize values in svn:keywords

Max Bowsher wrote:
> I propose that we need to sort out whether issue 890 (custom keywords)
> requires any extended syntax in svn:keywords before we proceed with
> keyword canonicalisation.

Having spent a lot of time thinking about custom keywords over the past year,
this patch in no way interferes with anything we do about custom keywords
(IMHO). It is strictly about fixing the misfeature that the contents of
svn:keywords aren't case-sensitive and the keywords inside files are.

Any custom keyword handling should be overlayed on top of the existing keywords,
not relying on specialized syntax within svn:keywords. Custom keywords are
almost certainly going be deeply involved with issue #1974 (and the others
similar server side config issues).

As long as the revised patch ignores all keywords that are not "core" then we
are set for future expansion. At some point, the else{} that Madan added can be
extended with a call to validate repository-defined keywords in addition to the
builtin keywords, and old clients will not break (but they also won't get the
custom keyword expansion).

My 2 cents

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org