[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13855 - in trunk/subversion: include libsvn_fs_base libsvn_fs_fs libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_subr libsvn_wc mod_dav_svn svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-04-04 20:05:31 CEST

On Sat, 2005-04-02 at 10:06, jpieper@tigris.org wrote:
> Do not assume that svn_md5_digest_to_cstring will always return a
> valid string. If its input digest is all 0's, it will return a NULL
> instead.

Wow. What a horrible botch (not yours).

What if a file happens to digest to all-zeros? If the filesystem code
is going to special-case this particular digest, then the special case
should be in the filesystem code, not buried deep in libsvn_subr.

> Adjust all callers to either handle the NULL correctly, or
> use a new function that will always return an actual string.

I'd prefer the new function be called svn_digest_to_cstring2, and the
old function be deprecated.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 20:06:58 2005

This is an archived mail posted to the Subversion Dev mailing list.