[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13827 - in trunk/subversion: libsvn_ra_dav mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2005-04-04 15:47:22 CEST

kfogel@collab.net writes:

> cmpilato@tigris.org writes:
> > --- trunk/subversion/mod_dav_svn/update.c (original)
> > +++ trunk/subversion/mod_dav_svn/update.c Fri Apr 1 09:34:50 2005
> > @@ -1189,6 +1189,19 @@
> > if (strcmp(child->first_cdata.first->text, "no") != 0)
> > resource_walk = TRUE;
> > }
> > + if (child->ns == ns && strcmp(child->name, "text-deltas") == 0)
> > + {
> > + if (! child->first_cdata.first)
> > + return dav_new_error_tag(resource->pool, HTTP_BAD_REQUEST, 0,
> > + "The request's 'text-deltas' element contains empty cdata; "
> > + "there is a problem with the client.",
> > + SVN_DAV_ERROR_NAMESPACE,
> > + SVN_DAV_ERROR_TAG);
> > +
> > + /* ### assume no white space, no child elems, etc */
> > + if (strcmp(child->first_cdata.first->text, "no") == 0)
> > + text_deltas = FALSE;
> > + }
> > }
>
> Why the "###" in that comment?

That block is a modified copy-n-paste from neighboring ones (all of
which have that '###' comment, and that because if we decide to do a
"triple-hash-cleanup" someday, we'll want to tighten up those pieces
of code so that they no longer make the listed assumptions.

> (Rest of change looks great, btw!)

Of course it does -- it's written in red. Oh, wait. That's just my
Gnus coloration...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 4 16:23:15 2005

This is an archived mail posted to the Subversion Dev mailing list.