[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Message cleanups.

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-04-03 17:27:15 CEST

Kobayashi Noritada wrote:
> Hi,
>
> From: "Max Bowsher" <maxb@ukf.net>
> Subject: Re: [PATCH] Message cleanups.
> Date: Fri, 1 Apr 2005 18:58:05 +0100
>
>> Kobayashi Noritada wrote:
>>> * subversion/libsvn_repos/load.c: Make messages showing working
>>> state such as " * editing path : %s ..." and " done.\n"
>>> similar to "Deltifying revision %ld..." and "done.\n" in
>>> svnadmin/main.c.
>>
>> I don't like this change.
>>
>> The outputs are fairly dissimilar even after the patch is applied,
>> so I'd prefer those messages were left unchanged.
>>
>> All the rest are probably ok, although I haven't examined them
>> closely.
>
> Thank you for your comment.
> So, I changed my patch not to change forms of those messages but just
> to capitalize them.
> Is it OK?

I'd rather not change them at all. Even in case. I think their current
non-capitalization agrees with their purpose as subordinate notifications to
the lines notifying about revision numbers.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 3 17:33:34 2005

This is an archived mail posted to the Subversion Dev mailing list.