[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: propchange - r13838 - svn:log

From: <kfogel_at_collab.net>
Date: 2005-04-03 06:33:36 CEST

Justin Erenkrantz <justin@erenkrantz.com> writes:
> The issue is that I didn't really intend to commit dist.sh at that
> time. My goal was to get 1.1.4 out for review - the dist.sh log was,
> IMHO, less important to clean up immediately and I haven't had any
> 'Net access since I sent the email regarding 1.1.4. (Yet, that script
> was what I used to produce the release.)
>
> I will fix up the log message later this evening. My apologies - I
> didn't intend to commit it at that time, but it wasn't really possible
> (nor feasible) for me to revert those changes at that time.

Sure, understood. If that happens again, just quickly propedit the
log message to say that you're planning to fix it up later -- that
would be the best short-term solution, IMHO.

> The issue is that I thought dist.sh was associated with the branch
> that it was producing a release for - not the trunk which is a
> different release line. If that is incorrect, then I can merge
> whatever changes back into the trunk and also make it much more
> explicit to only use trunk/dist.sh in the docs. (Perhaps we should
> remove dist.sh from the branches?) -- justin

I always assumed we were treating dist.sh like any other piece of
Subversion -- making master changes on trunk, and porting them outward
to branches as necessary. Any deviation from that adds unexpected
complexity, so IMHO it would have to be a very big benefit to be worth
the added complexity. In this case, I'm not sure what the benefit
would be. Why can't we just treat dist.sh normally?

However, in the case of these *particular* changes, don't port them
back to trunk just yet. Frankly I think the best course would be to
revert them on the branch, then have our discussion here about what we
want to do to dist.sh (since there is clearly some disagreement), and
then when agreement is reached, make the appropriate changes on trunk.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 3 06:59:45 2005

This is an archived mail posted to the Subversion Dev mailing list.