[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test case improvement for Issue #2214

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-04-03 03:31:17 CEST

Madan US wrote:
> On Fri, 2005-04-01 at 17:46, Julian Foad wrote:
>>Madan US wrote:
>>> Improved test for Issue #2214: poor error message when
>>> intermediate dir missing in copy.
>>>
>>> * subversion/tests/clients/cmdline/copy_tests.py
>>> (url_to_non_existent_url_path): Improved to
>>> check for exact error message
[...]
> I will make this change along
> with the extra space removal thing below and send the patch again.

No need - I have committed it, with some tweaks, in r13865.

>>You have removed the username and password options but not mentioned that
>>change in the log message. Why?
>
> I thought the log message should capture the major reason for change.
> Should we write all the changes in the logs? Pl. correct me if I'm
> wrong.

All of the significant changes should be mentioned, at least in the detailed
part of the log message. There is no need to mention insignificant changes,
such as small changes to white space or to the value of the meaningless commit
log message ("fooogle" -> "marina"), but in this case it was not clear to me
that the removal of authentication options was an insignificant change.

> And specifically, the reason for change is that it is not required. I
> believe the svntest module uses a default username and password even if
> not provided.

I noticed that the authentication options are still present in many places in
that file, so I left them to be removed as part of a separate clean-up.
Likewise I left out your change of commit message as it didn't seem to be
useful. Those meaningless messages could be reduced to empty messages as part
of a separate clean-up (though that's hardly worth bothering with).

Thanks for the patch.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 3 03:32:40 2005

This is an archived mail posted to the Subversion Dev mailing list.