[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Locking tests to verify 'svn status'

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-04-03 00:00:22 CEST

Ram, thanks for these tests, they're what we need.

I have a request, though: I really dislike the fact that every new
test written these days only ever calls run_and_verify_svn(). It's
very quick and easy, but it also gives extremely poor coverage. I'd
like to see these tests rewritten to use run_and_verify_status(), so
that the *entire* output of 'svn status -uvq' is verified. It's not
very robust to just grep for one string and be done. Take a look at
the examples in basic_tests.py, or update_tests.py or commit_tests.py.

It may be the case that we'll need to update the status-parser in
tree.py to return the "KOBT" column as a tree-node attribute, but
that's not a big deal to tweak. Karl may have already done that this
week.

On Apr 2, 2005, at 2:40 PM, S.Ramaswamy wrote:

> Locking tests to verify output of 'svn status' and 'svn status -u'.
>
>
> ChangeLog :
>
> * subversion/tests/clients/cmdline/lock_tests.py
> (lock_status) : New. Verify 'svn stat' on a
> working copy path with a locked file.
>
> (repository_lock_status) : New. Verify 'svn stat -u'
> from a working copy having the lock representation
> and another working copy.
>
> (stolen_lock_status) : New. Verify 'svn stat -u'
> after stealing the lock from another working copy.
>
> (broken_lock_status) : New. Verify 'svn stat -u'
> after breaking the lock from another working copy.
>
> (test_list) : Added lock_status, repository_lock_status,
> stolen_lock_status, and broken_lock_status to the list
> of tests.
>
>
>
>
>
>
> <lock_status_tests.patch>----------------------------------------------
> -----------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 3 00:03:50 2005

This is an archived mail posted to the Subversion Dev mailing list.