Marcus Rueckert <darix@web.de> writes:
> Add a function to mod_dav_svn to get the path of the repository on diski.
> This can be usefull for other apache modules.
s/diski/disk/
s/usefull/useful/
s/apache/Apache/
> * subversion/mod_dav_svn/mod_dav_svn.c
> (dav_svn_get_repos_path): Set *repos_path to the path to the repository on disk.
>
> Include mod_dav_svn.h so we get the prototype for
> dav_svn_get_repos_path and dav_svn_split_uri.
>
> * subversion/include/mod_dav_svn.h
> (dav_svn_get_repos_path): Declare the function and make it public for other
> apache modules.
Noisy. You just need:
Add a function to mod_dav_svn to get the path of the repository on disk.
This can be useful for other Apache modules.
* subversion/include/mod_dav_svn.h
(dav_svn_get_repos_path): New.
* subversion/mod_dav_svn/mod_dav_svn.c
Include mod_dav_svn.h.
(dav_svn_get_repos_path): New.
> Index: subversion/include/mod_dav_svn.h
> ===================================================================
> --- subversion/include/mod_dav_svn.h (revision 13816)
> +++ subversion/include/mod_dav_svn.h (working copy)
> @@ -74,6 +74,13 @@
> const char **repos_path);
>
>
> +/* Given an apache request R and a ROOT_PATH to the svn location
> + block set *REPOS_PATH to the path of the repository on disk.
> +*/
> +AP_MODULE_DECLARE(dav_error *) dav_svn_get_repos_path(request_rec *r,
> + const char *root_path,
> + const char **repos_path);
Docstring is fine, I guess. Were it my patch, I might do the
following instead:
/* Set *REPOS_PATH to the on-disk path of the repository associated
with Apache request R and a <Location> block ROOT_PATH. */
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 1 17:58:45 2005