[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] dav_svn_get_repos_path

From: Marcus Rueckert <darix_at_web.de>
Date: 2005-04-01 17:23:21 CEST

On 2005-04-01 14:35:01 +0100, Julian Foad wrote:
> The direction of "from" is ambiguous - it can sounds like we are getting
> the path from them. Maybe: "Add a function to mod_dav_svn to get the path
> of the repository on disk. This can be useful to other Apache modules."

thanks. :) i just took your text :)

> No indentation needed before "*".

fixed. i copy pasted the examples from the hacking file and didnt look
at the log inbetween. :)
 
> Full stops would be nice.

i added some. :)
 
> Delete "for" (or "to the").

done
 
> "block, set *REPOS_PATH to the path to the repository on disk."
> (It returns an error code.)

done.
 
> Please don't ask questions in the source comments. When possible, ask the
> questions on the mailing list and put the answers into the comments as
> facts. Otherwise each developer that looks at this will wonder, "I don't
> know ... is this right or not? This code shouldn't have been committed
> unless the original programmer was sure."

was an old comment. i removed the apr_pstrdup() but not the comment.
 
> We can? Then what was the purpose of the previous function call?

can i have an old comment obsoleter pleae. removed.
 
> "Now let's"

fixed

thanks for your review julian.

ready for the next round. new patch attached. :)

darix

-- 
irssi - the client of the smart and beautiful people
              http://www.irssi.de/



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Apr 1 17:24:32 2005

This is an archived mail posted to the Subversion Dev mailing list.