[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Test case improvement for Issue #2214

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-04-01 14:16:48 CEST

Madan US wrote:
> Sending for the third time. Committers pl. comment.

I saw it every time you posted it. Please leave more than a day between
re-posts unless it is urgent. I go away for several days at a time.

This patch doesn't seem very important, but I apologise for not commenting at all.

> [[[
> Improved test for Issue #2214: poor error message when
> intermediate dir missing in copy.
>
> * subversion/tests/clients/cmdline/copy_tests.py
> (url_to_non_existent_url_path): Improved to
> check for exact error message
> ]]]

Thank you for noticing that "improvise" is not the same as "improve", and for
fixing it here, though your attached log message is still the old one. (There
is no need to re-post just to fix that.)

What is the reason for this change? There is no requirement for "svn" to
output this exact error message. On the other hand, your fix was to improve
the error message from an inappropriate one to this appropriate one, and for
that it might be worth having a regression test to ensure that the old error is
not brought back by a merge or whatever. OK, I suppose that is a sufficient
reason for this change.

> Index: subversion/tests/clients/cmdline/copy_tests.py
> ===================================================================
> --- subversion/tests/clients/cmdline/copy_tests.py (revision 13736)
> +++ subversion/tests/clients/cmdline/copy_tests.py (working copy)
> @@ -1482,19 +1482,23 @@
>
> sbox.build()
> wc_dir = sbox.wc_dir
> -
> - dirURL1 = svntest.main.current_repo_url + "/A/B/E"
> - dirURL2 = svntest.main.current_repo_url + "/G/C/E/I"
> -
> +

You inserted some long lines full of spaces here...

> + dirURL1 = svntest.main.current_repo_url + "/A/B/E"
> + dirURL2 = svntest.main.current_repo_url + "/G/C/E/I"
> + msg = ".*: Path 'G' not present"
> +

and here.

> # Expect failure on 'svn cp SRC DST' where one or more ancestor
> # directories of DST do not exist
> - svntest.actions.run_and_verify_svn(None, None, SVNAnyOutput,
> - 'cp', dirURL1, dirURL2,
> - '--username', svntest.main.wc_author,
> - '--password', svntest.main.wc_passwd,
> - '-m', 'fooogle')
> + out, err = svntest.main.run_svn(1,
> + 'cp', dirURL1, dirURL2,
> + '-m', 'marina')

You have removed the username and password options but not mentioned that
change in the log message. Why?

> + for err_line in err:
> + if re.match (msg, err_line):
> + break
> + else:
> + print "Error:\n" + msg + "\nnot found in error output:\n" + str(err)
> + raise svntest.Failure
>
> -

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 1 14:18:07 2005

This is an archived mail posted to the Subversion Dev mailing list.