[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make a string localizable

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-04-01 09:00:24 CEST

On Thu, 31 Mar 2005, Marcel Gosselin wrote:

> Patch to make a string localizable
>
> Right now the string is half localized.
>
> We would still need ngettext to have perfect behavior but this change
> should suffice for now
>
> [[[
> * info-cmd.c: Make a string localizable
> ]]]
>
Should be:
* subversion/clients/cmdline/info-cmd.c (print_info): Make a string
  localizable.

Index: subversion/clients/cmdline/info-cmd.c
===================================================================
--- subversion/clients/cmdline/info-cmd.c (revision 13817)
+++ subversion/clients/cmdline/info-cmd.c (working copy)
@@ -202,9 +202,10 @@
           /* NOTE: The stdio will handle newline translation. */
           comment_lines = svn_cstring_count_newlines (info->lock->comment) + 1;
           SVN_ERR (svn_cmdline_printf (pool,
- _("Lock Comment (%i %s):\n%s\n"),
+ (comment_lines > 1)

That test should be !=. Otherwise you'd get "0 line". (In this particular
case, it doesn't matter, since it will never be 0, but it is more readable
tohandle plurals in a consistent way.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 1 08:56:35 2005

This is an archived mail posted to the Subversion Dev mailing list.