Re: [PATCH] Include offending XML in "Malformed XML" error message

On Sun, 27 Feb 2005, Charles Bailey wrote:

> On Sun, 27 Feb 2005 22:25:11 +0100 (CET), Peter N. Lundblad
> <peter@famlundblad.se> wrote:
[snip discussion about ensuring that the error stirng is valid UTF8]

> This looks like a SMOP, but I'm not sure what the real benefit is.
> Does Subversion make the guarantee that all of its output will be
> UTF-8? Unless that's a major goal, I think there's something to be
> said for inserting the offending XML "as is" into the error message.

Not its output, but the strings internally. With few exceptions our APIs
work with UTF8 internally. The problem with adding "raw data" is that the
error message will be invalid UTF8 and you will have recoding errors
later. Our own error output routines will escape the whole string then,
but that might not other libraries do. So, yes, keeping our strings valid
UTF8 is a goal.

> If it is a general policy to convert to UTF-8, should I code this as a
> separate function, rather than putting the logic into parse_xml?
>
You can put it in a separate function. Keep it internal to the file,
though, until we see another use case for it. We can export it if that
happens.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 28 08:10:58 2005