[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13063 - trunk/subversion/libsvn_fs_base

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-02-26 12:00:40 CET

Philip Martin wrote:

>How about something like this, no cast and no warnings:
>
>Index: subversion/libsvn_fs_base/reps-strings.c
>===================================================================
>--- subversion/libsvn_fs_base/reps-strings.c (revision 13157)
>+++ subversion/libsvn_fs_base/reps-strings.c (working copy)
>@@ -324,7 +324,8 @@
> do
> {
> struct compose_handler_baton cb = { 0 };
>- char *source_buf, *target_buf;
>+ const char *source_buf;
>+ char *target_buf;
>
>
[...]

After some discussion on IRC and some digging into the code, it turns
out that we can just set source_buf to NULL when we know it's not going
to be used. I'm on this now.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 26 12:02:02 2005

This is an archived mail posted to the Subversion Dev mailing list.