[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix mod_dav exports on Windows

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-02-25 22:35:06 CET

Justin Erenkrantz wrote:

> --On Wednesday, February 23, 2005 3:07 AM +0100 "Branko ?ibej"
> <brane@xbc.nu> wrote:
>> A number of public functions in mod_dav.h aren't properly exported with
>> DAV_DECLARE. This recently became a problem for Subversion, because
>> mod_dav_svn now supports DAV locking, and mod_dav's locking functions
>> were
>> amongst the ones that were not exported. Nobody noticed this on Unix
>> where
>> DAV_DECLARE is a no-op, but Windows suffered mightily.
>> The attached patch (against the 2.0.x branch) fixes the problem. I
>> had to
>> use DAV_DECLARE_NONSTD in a few places where the functions are used as
>> callbacks, because I didn't want to fiddle with the __stdcall horror in
>> callback parameter declarations.
>> Subversion 1.2, which will introduce locking functionality, will not
>> work as
>> a DAV server on Windows without an httpd-2.0.x release that includes
>> this
>> patch. I hope such a thing is possible in the next few months, and
>> I'm only
>> sorry I was too late for the the 2.0.53 release.
> I've committed it to trunk and have proposed it for backport. -- justin

Thanks! Sorry I didn't provide a patch for trunk; I'm swamped these days
and simply hadn't got around to it.

> P.S. I had 'fun' trying to get your name in the commit log. I hope I
> got it right... =)

Ah! I'm afraid you seem to have failed. trying, anyway. This would
probably work:

  env LANG=en_US.UTF-8 svn propedit --revprop -r??? svn:log https://svn.apache.org/repos/asf/httpd/httpd

then paste in the name from Subversion's COMMITTERS file.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 25 22:53:23 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.