[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 2154 - svn blame on a directory over DAV does not return gracefully

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-02-25 16:58:41 CET

--On Friday, February 25, 2005 3:11 PM +0530 VK Sameer <sameer@collab.net>
wrote:

> Attached is a patch, including a test case, for issue 2154. make check
> passes.
>
> There are still some unanswered questions which somebody with greater
> familiarity with mod_dav_svn may be able to answer. Or I'll re-visit
> this once I've looked into a few more mod_dav issues. The question is
> why the goto cleanup: blows away the 500 status and picks up the default
> 200 status. I also don't see why a 0 is being returned in the http body.

No, it's that the cleanup branch calls ap_fflush. flush will tell httpd to
write the HTTP headers out and that includes whatever r->status is at that
particular time. When we call convert_err, we don't immediately set r->status
right then - so r->status remains 0. Hence, HTTP status 200 is returned.

So, your patch is fine as we don't want to call flush. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 25 17:00:00 2005

This is an archived mail posted to the Subversion Dev mailing list.