[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r13137 - branches/ruby/subversion/bindings/swig/ruby/svn

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-02-24 22:06:40 CET

kou@tigris.org wrote:
> Author: kou
> Date: Thu Feb 24 06:21:08 2005
> New Revision: 13137
>
> Modified:
> branches/ruby/subversion/bindings/swig/ruby/svn/client.rb
> branches/ruby/subversion/bindings/swig/ruby/svn/delta.rb
> branches/ruby/subversion/bindings/swig/ruby/svn/fs.rb
> branches/ruby/subversion/bindings/swig/ruby/svn/ra.rb
> branches/ruby/subversion/bindings/swig/ruby/svn/repos.rb
> branches/ruby/subversion/bindings/swig/ruby/svn/wc.rb
> Log:
> Add some requires for convinient.

I think you mean "Add some requires for convenience."

> * subversion/bindings/swig/ruby/svn/client.rb:
> subversion/bindings/swig/ruby/svn/ra.rb:
> subversion/bindings/swig/ruby/svn/repos.rb:
> subversion/bindings/swig/ruby/svn/delta.rb:
> subversion/bindings/swig/ruby/svn/wc.rb:
> Add 'require "svn/core"'.
>
> * subversion/bindings/swig/ruby/svn/fs.rb:
> Change `require "svn/repos"' order.

Please don't use strange quotes: Change ` to ' .

Please could you fix the log message.

> Modified: branches/ruby/subversion/bindings/swig/ruby/svn/client.rb
> Url:
> http://svn.collab.net/viewcvs/svn/branches/ruby/subversion/bindings/swig/ruby/svn/client.rb?view=diff&rev=13137&p1=branches/ruby/subversion/bindings/swig/ruby/svn/client.rb&r1=13136&p2=branches/ruby/subversion/bindings/swig/ruby/svn/client.rb&r2=13137
> ==============================================================================
> --- branches/ruby/subversion/bindings/swig/ruby/svn/client.rb (original)
> +++
> branches/ruby/subversion/bindings/swig/ruby/svn/client.rb Thu Feb 24
> 06:21:08
> 2005 @@ -1,6 +1,8 @@
> require "English"
> require "svn/error"
> require "svn/util"
> +require "svn/core"
> +require "svn/fs"

The addition of "svn/fs" is not documented in the log message, nor is it
correct, since the client module is nothing to do with the fs module.

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 24 22:08:39 2005

This is an archived mail posted to the Subversion Dev mailing list.