[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_svn log limit and compat

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-02-24 02:32:11 CET

Chia-liang Kao wrote:
> On Wed, Feb 23, 2005 at 11:01:53AM -0500, Garrett Rooney wrote:
>>Well, I can "fix" it in that I can make it work similarly to the way it
>>works via DAV, just pulling down all the data and dropping it on the
>>floor, but that kind of sucks since it means you have to actually wait
>>for the whole log response to come back before you can return control to
>>the user.
>>Honestly, I never expected people to be reusing the connection...
> svk reuses ra session wherever possible.
>>Can anyone think of a better way to deal with this?
> I've just committed workaround to svn::mirror::ra, to use my own
> limit-emulating thing for 1.1 clients. It works in the way that
> several get_log are called to construct the wanted limited logs
> as close as possible.

I don't think there's any reason to add compat code... I mean --limit
doesn't actually roll out until 1.2, so people will only see it in dev
versions of the code. Here's a patch to make ra_svn work like ra_dav,
please give it a shot and let me know if it solves your problem.


Index: subversion/libsvn_ra_svn/client.c
--- subversion/libsvn_ra_svn/client.c (revision 13132)
+++ subversion/libsvn_ra_svn/client.c (working copy)
@@ -1105,11 +1105,10 @@
         cphash = NULL;
- if (limit && ++nreceived > limit)
- break;
+ if (! (limit && ++nreceived > limit))
+ SVN_ERR(receiver(receiver_baton, cphash, rev, author, date, message,
+ subpool));
- SVN_ERR(receiver(receiver_baton, cphash, rev, author, date, message,
- subpool));

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 24 02:33:42 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.